Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug build target #4664

Closed
wants to merge 70 commits into from
Closed

add debug build target #4664

wants to merge 70 commits into from

Conversation

u8-Salem
Copy link

@u8-Salem u8-Salem commented May 30, 2024

Adds a debug build target

Description

make debug will build separate artifacts in build/(modern-)debug and enable -Og and -g.
for agbcc it will enable -O1 and -g
Also adds the option to run any build with NOOPT=1 remove any optimization flags

sets all debug menu options in config/debug.h to false by default. the debug target turns all of these options on by default.
To achieve this, any preproc directive regarding these menus has been removed and integrated in the regular control flow.

Also fixes an error that reveals when building with debug (Werror=maybe-uninitialized)

Discord contact info

u8.salem

@u8-Salem u8-Salem closed this May 30, 2024
@u8-Salem u8-Salem reopened this May 30, 2024
@u8-Salem u8-Salem marked this pull request as draft May 30, 2024 19:48
@u8-Salem u8-Salem changed the base branch from master to upcoming June 1, 2024 17:30
AsparagusEduardo and others added 27 commits June 7, 2024 12:25
* newer generation soundproof heal bell interactions

* Fix bugs and rewrite AnyPartyMemberStatused

* add missing check, tests, clean up

* fix ai code and rename battler for clarity
* Add followers to readme & update migration script readme

* Apply suggestions from code review

Co-authored-by: Eduardo Quezada <[email protected]>

* Update README.md

Co-authored-by: Eduardo Quezada <[email protected]>

---------

Co-authored-by: Eduardo Quezada <[email protected]>
* Tera Shell AI calcs

* agbcc
`src/data/map_group_count.h` is currently in `.gitignore`. However, git
does not ignore a file if that file is already in the index. To actually
ignore the file, the file must be deleted and that deletion must be
committed.

In addition, the Makefile did not previously clean `src/data/map_group_count.h`,
nor know how to generate `src/data/map_group_count.h`.
It did generate the file as a side-effect of a different rule, but if
asked to generate, it did not know how to.
* Rename files to PSV

* Rename functions and defines

* Add missing newlines

* Integrate feedback
…pr/upcoming/bwPopupMergeFix

# Conflicts:
#	include/field_weather.h
#	include/rtc.h
#	include/strings.h
#	src/field_weather.c
#	src/map_name_popup.c
#	src/menu.c
#	src/rtc.c
#	src/strings.c
@u8-Salem u8-Salem closed this Jun 16, 2024
@u8-Salem u8-Salem mentioned this pull request Jun 16, 2024
@u8-Salem u8-Salem deleted the noopt branch August 4, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants