Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Bassoonian <[email protected]>
  • Loading branch information
pkmnsnfrn and Bassoonian authored Dec 31, 2024
1 parent dcdc64b commit abd710f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

## Description
<!--- Describe your changes in detail -->
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/schedule.md, please let a maintainer know! -->
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/schedule.md, please let a Maintainer know! -->

## Images
<!-- Please provide with relevant GIFs or images to make it easier for reviewers to accept your PR quicker.-->
Expand Down
2 changes: 1 addition & 1 deletion docs/schedule.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ PRs that DO NOT have the Github labels [`bugfix`](https://github.com/rh-hideout/
## Release Blocking and Milestones
When an issue or PR is assigned to a [milestone on Github](https://github.com/rh-hideout/pokeemerald-expansion/milestones) by a Maintainer, that means it is "Blocking". If another Maintainer agrees with this, then that version cannot be released until that issue is resolved or PR is merged.

This desgination should be reserved for instances where an existing feature on `upcoming` or `master` is broken and causing problems for users or players.
This designation should be reserved for instances where an existing feature on `upcoming` or `master` is broken and causing problems for users or players.

Blocking issues or PRs can be deferred to future releases but should be discussed with the Maintainers that assigned the designation in the first place.

Expand Down

0 comments on commit abd710f

Please sign in to comment.