Support certs with GeneralTime
#167
Open
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# Background
Recert until now only supported certs with asn1 `UTCTime` and not
`GeneralizedTime`.
# Problem
When golang creates certs with expiration way out in the future, it uses
`GeneralizedTime` instead of `UTCTime`.
For example:
```
4:d=2 hl=2 l= 13 prim: UTCTIME :240607174402Z
19:d=2 hl=2 l= 17 prim: UTCTIME :340605194402+0200
```
vs
```
4:d=2 hl=2 l= 13 prim: UTCTIME :240607174406Z
19:d=2 hl=2 l= 19 prim: GENERALIZEDTIME :21240514194406+0200
```
Usually this is not a problem, because a typical OCP cluster doesn't
have certs this far in the future, but eventually it will become a
problem. Also RHOAI has a component (tektoncd) that has certs with
expiry 100 years in the future [1] (despite the misleading name that
says "Decade" rather than "Century").
Trying to recert a cluster with tektoncd will therefore lead to the
following error:
```
error: |-
scanning and recertification
Caused by:
0: processing discovered objects
1: regenerating crypto
2: re-signing cert with subject CN=tekton-triggers-core-interceptors.openshift-pipelines.svc, O=knative.dev
3: mutating cert
4: extending expiration
5: forcefully expiring
6: evaluating current expiration
7: GeneralTime not supported
```
# Solution
This PR adds support for asn1 generalized time in recert. It's simply a
matter of casting the type correctly, the x509_certificate crate already
supports it.
# Testing
This PR is untested, waiting for feedback from the user that reported
the issue.
[1] https://github.com/tektoncd/triggers/blob/59da11dd50424c9ccef883b558671e34efc0eba5/pkg/interceptors/server/server.go#L36
omertuc
added a commit
to omertuc/triggers
that referenced
this pull request
Oct 10, 2024
We had an issue [1] with long expiration so I noticed the name was wrong [1] rh-ecosystem-edge/recert#167
omertuc
added a commit
to omertuc/triggers
that referenced
this pull request
Oct 10, 2024
We had an issue [1] with long expiration so I noticed the name was wrong [1] rh-ecosystem-edge/recert#167
7 tasks
omertuc
added a commit
to omertuc/triggers
that referenced
this pull request
Oct 10, 2024
We had an issue [1] with long expiration so I noticed the name was wrong [1] rh-ecosystem-edge/recert#167 Signed-off-by: Omer Tuchfeld <[email protected]>
tekton-robot
pushed a commit
to tektoncd/triggers
that referenced
this pull request
Nov 4, 2024
We had an issue [1] with long expiration so I noticed the name was wrong [1] rh-ecosystem-edge/recert#167 Signed-off-by: Omer Tuchfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Recert until now only supported certs with asn1
UTCTimeand notGeneralizedTime.Problem
When golang creates certs with expiration way out in the future, it uses
GeneralizedTimeinstead ofUTCTime.For example:
vs
Usually this is not a problem, because a typical OCP cluster doesn't have certs this far in the future, but eventually it will become a problem. Also RHOAI has a component (tektoncd) that has certs with expiry 100 years in the future (despite the misleading name that says "Decade" rather than "Century").
Trying to recert a cluster with tektoncd will therefore lead to the following error:
Solution
This PR adds support for asn1 generalized time in recert. It's simply a matter of casting the type correctly, the x509_certificate crate already supports it.
Testing
This PR is untested, waiting for feedback from the user that reported the issue.