Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update #50

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

asbjornu
Copy link
Member

@asbjornu asbjornu commented Sep 6, 2021

Implement auto-update. Resolves #47. Still a draft as I'm inching my way forward. Current status:

  • Installation of NPM packages via package.json.
  • Auto-update of NPM packages via package-lock.json.
  • Installation of APK packages via apk.json.
  • Auto-update of APK packages via apk.json.

I went for the separate package file solution since I think that's a cleaner and more maintainable approach than providing custom regex configuration for Renovate. The PR currently fails the runner / markdown-lint (github-pr-review) workflow due to the following command:

reviewdog -f=remark-lint -name=remark-lint -reporter=github-pr-review -filter-mode=added -fail-on-error=false -level=error -tee '-filter-mode=file -fail-on-error'

producing the following error:

invalid value "file -fail-on-error" for flag -filter-mode: invalid mode name: file -fail-on-error

I don't really understand why, so any pointers would be very helpful.

@rickstaa
Copy link
Member

@asbjornu Thanks for the work you have done. I am a bit short on time this month, but I will investigate the error when I find some time.

@rickstaa
Copy link
Member

It looks like migrating to a composite action #57 solves the errors that were thrown. @asbjornu Can you check if your other problems are also solved?

@rickstaa
Copy link
Member

@asbjornu If you still planning to implement this feature, I think it now works better on v5.0.0.

@rickstaa rickstaa removed their request for review February 18, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic update of packages in the Docker image
2 participants