Add escape hatch for when one doesn't want prepare_query
#184
+79
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a way of configuring specific schemas to not get `deleted_at` clauses automatically.
grossvogel
reviewed
Oct 28, 2024
There was a problem hiding this comment.
This seems like a reasonable thing to add to the library, I just have two small reasons for hesitating to approve and merge it outright:
- the name of the option being added,
skip_prepare_query?feels a little too tied to the implementation and not obvious enough from the perspective of a library user. I'm thinking maybeauto_exclude_from_queries?(defaulting totrue) or something like that would be clearer - we might want to add an example in the README to make people aware of the option, though I can see why we wouldn't want to do that if we don't expect it to be widely used
|
@grossvogel Yup, I struggled to name this option, and I agree your suggestion is better 👍 About the readme example, I can add it too |
grossvogel
approved these changes
Oct 28, 2024
grossvogel
requested review from
Dacello,
texastoast,
thebriz24,
pjdiiori and
estreeper
pjdiiori
approved these changes
Oct 28, 2024
nschello
reviewed
Oct 28, 2024
texastoast
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way of configuring specific schemas to not get
deleted_atclauses automatically.This is especially useful for issues like #100