drop useless malloc configure check #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ørjan Malde <[email protected]>
ludo-c
reviewed
May 24, 2023
| @@ -14,7 +14,6 @@ AC_CHECK_HEADERS([stdlib.h string.h unistd.h sys/prctl.h]) | |||
|
|
|||
| # Checks for library functions. | |||
| AC_FUNC_FORK | |||
| AC_FUNC_MALLOC | |||
| AC_CHECK_FUNCS([alarm sqrt strerror]) | |||
There was a problem hiding this comment.
It is still needed to check that a malloc function exists, it can be done in AC_CHECK_FUNCS.
Suggested change
| AC_CHECK_FUNCS([alarm sqrt strerror]) | |
| AC_CHECK_FUNCS([alarm malloc sqrt strerror]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test were to fail due to cross-compilation it will rename malloc to rpl_malloc which comes from gnulib resulting in a linking failure, lets assume malloc simply works instead.