Improvements for local and test usage #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change anything when paths are given explicitly (such as in the list of changed files on PRs), but when directories are given in local or test usage, and we are expanding them, we now exclude hidden files. I think this makes the most sense: match the behavior of a recursive `ls`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running something like
restyle .was behaving oddly, including lots of.gitandnode_modules, which I expected to be excluded.This was due to a confluence of issues that don't occur when the list of
changed files in a PR are the arguments passed -- which is why I'd not
encountered the error before.
Basically, expansion of the
.directory:./..., which causes excludes not to matchWe still have some bugs in our excludes, which we inherit from
System.FilePath.Glob's implementation of**/, but fixing issue (2) there mostlyavoids them.
Truncate paths in debug messages
1696229
Normalise paths before processing excludes
94f0268
Avoid hidden files in expanding arguments
25c2510
This doesn't change anything when paths are given explicitly (such as in
the list of changed files on PRs), but when directories are given in
local or test usage, and we are expanding them, we now exclude hidden
files. I think this makes the most sense: match the behavior of a
recursive
ls.Version bump
2a6ce9c