Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Restyled workflow on closed PR actions #277

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

pbrisbin
Copy link
Member

When this workflow runs on a closed PR action:

  1. Restyler skips due to the PR being closed, which means
  2. There is no diff, which means
  3. create-pull-request-action deletes the restyled branch, which means
  4. GitHub closes the Restyled PR

So simply including this action type brings back the "clean up on close"
behavior we want.

The only annoying thing is once you add this list, you now have to
re-include the default non-closed actions we want to run on, which,
thankfully, aren't that many.

When this workflow runs on a `closed` PR action:

1. Restyler skips due to the PR being closed, which means
2. There is no diff, which means
3. `create-pull-request-action` deletes the restyled branch, which means
4. GitHub closes the Restyled PR

So simply including this action type brings back the "clean up on close"
behavior we want.

The only annoying thing is once you add this list, you now have to
re-include the default non-`closed` actions we want to run on, which,
thankfully, aren't that many.
@pbrisbin pbrisbin merged commit 267ea32 into main Sep 24, 2024
7 checks passed
@pbrisbin pbrisbin deleted the pb/restyle-closed branch September 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant