Add --no-pull, --dry-run, refactor effect typeclasses #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an explicit pull, so this should not change anything. However, we're about to introduce a `--no-pull` option to prevent that (for when running something only locally-built, as in restyler testing), and it would be mildly confusing if the `docker-run` still pulled even if you were using `--no-pull`.
- Move `Git` and `Docker` under `Monad` namespace
- Break up `MonadSystem` into `Monad{Directory,{Read,Write}File}`
- Rewrite `FS` and update specs
pbrisbin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we test restylers we might build a tag then run it. Without
the explicit pull step, this was fine. But with the explicit pull step
it attempts to pull even though the image exists locally. To avoid
this, we built ourselves
--no-pull.Add --pull=never to docker-run invocation
73ca252
We have an explicit pull, so this should not change anything. However,
we're about to introduce a
--no-pulloption to prevent that (for whenrunning something only locally-built, as in restyler testing), and it
would be mildly confusing if the
docker-runstill pulled even if youwere using
--no-pull.Derive more options ThroughOptions on TestApp
732c9c0
Add --no-pull
0b4692e
Update --help in README
e4e4a4d
Break up MonadSystem
153371e
GitandDockerunderMonadnamespaceMonadSystemintoMonad{Directory,{Read,Write}File}FSand update specsRe-enable RunSpec via new MonadDocker test instance
Pull weed
1bb45c9
fixup! Pull weed
e772a1e
Add --dry-run
f30899f