[TaskCenter] Requests cancellation of managed runtimes #2364
+112
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets task center request the graceful cancellation of the root-future of managed runtimes. Note that it'll not wait for the shutdown to complete. If this is needed, then partition-processor managed will need to wait for the result to come when it receives the cancellation signal on its own cancellation token.
|
Partially solves #2341, for the solution to be complete, we need PPM to "await" the oneshot receiver when it receives the cancellation signal. |
tillrohrmann
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Thanks for fixing the shutdown problem of the partition processors that I've introduced @AhmedSoliman. The changes look good to me. +1 for merging :-)
Comment on lines
+643
to
+646
| if let Some(runtime) = owner { | ||
| runtime.shutdown_timeout(Duration::from_secs(2)); | ||
| trace!("Runtime {} shutdown completed", name); | ||
| } |
There was a problem hiding this comment.
Should we add an expect to encode the invariant that we are the only owner of the runtime at this point?
There was a problem hiding this comment.
I'm not sure as it wouldn't impact correctness of the system. Let's add it when we face a scenario where we need to really be sure that we uphold it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets task center request the graceful cancellation of the root-future of managed runtimes. Note that it'll not wait for the shutdown to complete. If this is needed, then partition-processor managed will need to wait for the result to come when it receives the cancellation signal on its own cancellation token.
Stack created with Sapling. Best reviewed with ReviewStack.