Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition Processor no longer gets shut down properly #2341

Open
pcholakov opened this issue Nov 21, 2024 · 0 comments
Open

Partition Processor no longer gets shut down properly #2341

pcholakov opened this issue Nov 21, 2024 · 0 comments
Assignees
@AhmedSoliman
Labels
bug Something isn't working partition-processor

Comments

@pcholakov
Copy link
Contributor

Somewhere between 8109b5f and is there after 96f4bfc, the Partition Processor cancellation behavior changed and is no longer being cleanly stopped when the managed runtimes get shutdown.

This change or something connected to it might be causing the Partition Processor (which runs on the root future of the partition-specific runtime) not to get a shutdown signal anymore.

Originally posted by @pcholakov in 0cc9816
@pcholakov pcholakov added bug Something isn't working partition-processor labels Nov 21, 2024
pcholakov referenced this issue Nov 21, 2024
@tillrohrmann
Make PartitionProcessorManager asynchronous and handle shut down of PPs
0cc9816 
This commit makes the PartitionProcessorManager fully asynchronous and handles
the shut down of PPs as well as errors arising when starting the PP.

This fixes #2258.
@AhmedSoliman AhmedSoliman self-assigned this Nov 26, 2024
@AhmedSoliman AhmedSoliman mentioned this issue Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AhmedSoliman AhmedSoliman

Labels
bug Something isn't working partition-processor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AhmedSoliman @pcholakov