Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle when format target is empty string (# 473) #475

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

boltlessengineer
Copy link
Contributor

reference: #473

@boltlessengineer boltlessengineer merged commit c703d54 into main Sep 28, 2024
2 checks passed
@jrebs
Copy link

jrebs commented Sep 29, 2024

Thanks for trying to solve the problem I brought up in that PR, but this change doesn't appear to fix it. I have updated to 3.8.2 and when I hit that endpoint with a knowingly bad Bearer token, I get the big red ocean of error stack information. When I comment out utils.lua lines 329-331, I am presented with a usable 401 response. The gggqG call still seems to be blowing this up.

@boltlessengineer
Copy link
Contributor Author

@jrebs Can you open a separate issue so I can keep track of this there? That will be helpful.

I want to make sure exactly what is causing gq to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants