Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use CI tooling as defined in Composer #84

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/php-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
tools: phpunit:5
extensions: redis

- name: Setup problem matchers for PHP
Expand All @@ -37,7 +36,7 @@ jobs:
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

- name: Run PHPunit
run: phpunit --configuration phpunit.xml.dist
run: ./vendor/bin/phpunit --configuration phpunit.xml.dist

phpcs:
runs-on: ubuntu-latest
Expand All @@ -47,17 +46,20 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Setup PHPCS
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '7.4'
tools: cs2pr, phpcs
tools: cs2pr

- name: Install dependencies
run: composer install

- name: Setup problem matchers for PHP
run: echo "::add-matcher::${{ runner.tool_cache }}/php.json"

- name: Run PHPCS
run: phpcs -q --report=checkstyle lib | cs2pr
run: ./vendor/bin/phpcs -q --report=checkstyle lib | cs2pr

phpstan:
runs-on: ubuntu-latest
Expand All @@ -71,7 +73,6 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: '7.4'
tools: phpstan

- name: Setup problem matchers for PHP
run: echo "::add-matcher::${{ runner.tool_cache }}/php.json"
Expand All @@ -80,5 +81,5 @@ jobs:
run: composer install

- name: Run PHPStan
run: phpstan analyse lib -l1
run: ./vendor/bin/phpstan analyse lib -l1

4 changes: 3 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
"ext-redis": "Native PHP extension for Redis connectivity. Credis will automatically utilize when available."
},
"require-dev": {
"phpunit/phpunit": "^5.7"
"phpunit/phpunit": "^5.7",
"squizlabs/php_codesniffer": "^3.10",
"phpstan/phpstan": "^1.12"
},
"bin": [
"bin/resque",
Expand Down
Loading