Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/unskip playwright tests 2.0 #3287

Merged
merged 12 commits into from
Dec 23, 2024
Merged

Fix/unskip playwright tests 2.0 #3287

merged 12 commits into from
Dec 23, 2024

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Dec 16, 2024 •
edited
Loading

@clari182 clari182 mentioned this pull request Dec 16, 2024
Open
18 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (aab35bc) to head (451120b).
Report is 6 commits behind head on staging.

Additional details and impacted files 
@@           Coverage Diff            @@
##           staging    #3287   +/-   ##
========================================
  Coverage    97.17%   97.17%           
========================================
  Files           60       60           
  Lines        12334    12334           
  Branches       308      308           
========================================
  Hits         11986    11986           
- Misses         334      348   +14     
+ Partials        14        0   -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clari182 clari182 marked this pull request as ready for review December 20, 2024 14:48
@clari182 clari182 requested a review from pdcp1 December 20, 2024 20:07
pdcp1
pdcp1 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@pdcp1 pdcp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pdcp1 pdcp1 merged commit 4874084 into responsible-ai-collaborative:staging Dec 23, 2024
22 checks passed
@pdcp1 pdcp1 mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdcp1 pdcp1 pdcp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clari182 @pdcp1