Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add same touched behavior as inputs for text editor #3274

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (9fe3ac5) to head (9c23b39).

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #3274   +/-   ##
========================================
  Coverage    97.17%   97.17%           
========================================
  Files           60       60           
  Lines        12334    12334           
  Branches       308      213   -95     
========================================
  Hits         11986    11986           
- Misses         334      348   +14     
+ Partials        14        0   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create a new issue but the authors field doesn't display errors on blur either:

image

@clari182
Copy link
Collaborator Author

@cesarvarela I'd rather fix it in this PR. I also added a test to check that the required messages are displaying correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants