Prevent CSV export from crashing on missing fields #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3037 +/- ##
===========================================
- Coverage 96.49% 87.46% -9.03%
===========================================
Files 30 123 +93
Lines 8759 11101 +2342
Branches 128 986 +858
===========================================
+ Hits 8452 9710 +1258
- Misses 307 1253 +946
- Partials 0 138 +138 ☔ View full report in Codecov by Sentry. |
pdcp1
approved these changes
Aug 23, 2024
pdcp1
merged commit 0470e73
into
responsible-ai-collaborative:staging
13 of 19 checks passed
This was referenced Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3035
(I think the csv export component shouldn't do anything until it is clicked but that's another issue)