Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate classifications and taxa collections to API #3005

Conversation

cesarvarela
Copy link
Collaborator

@cesarvarela cesarvarela commented Aug 2, 2024

closes #3006

(The failing tests seem to be just flake, because it is not the same test that fails if look at each attemp)

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (staging@0a1e744). Learn more about missing BASE report.
Report is 10 commits behind head on staging.

Additional details and impacted files
@@            Coverage Diff             @@
##             staging    #3005   +/-   ##
==========================================
  Coverage           ?   96.73%           
==========================================
  Files              ?       35           
  Lines              ?     9408           
  Branches           ?      182           
==========================================
  Hits               ?     9101           
  Misses             ?      303           
  Partials           ?        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kepae kepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Killer. Let it rip when ready!

@@ -53,16 +54,35 @@ export const test = base.extend<TestFixtures>({

login: async ({ page }, use, testInfo) => {

// TODO: this should be removed since we pass the username and password as arguments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this TODO as an issue to ensure we remember to work on this change

@cesarvarela cesarvarela merged commit 54282d9 into responsible-ai-collaborative:staging Aug 26, 2024
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants