-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate rss.cy and signup.cy to Playwright #2907
Merged
cesarvarela
merged 15 commits into
responsible-ai-collaborative:staging
from
clari182:feature/playwright-rss-signup
Nov 5, 2024
Merged
Migrate rss.cy and signup.cy to Playwright #2907
cesarvarela
merged 15 commits into
responsible-ai-collaborative:staging
from
clari182:feature/playwright-rss-signup
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
clari182
commented
Jun 24, 2024
- closes Migrate rss.cy tests to Playwright #2905
- closes Migrate signup.cy tests to Playwright #2906
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2907 +/- ##
============================================
+ Coverage 84.13% 94.15% +10.02%
============================================
Files 164 112 -52
Lines 15403 13571 -1832
Branches 1335 686 -649
============================================
- Hits 12959 12778 -181
+ Misses 2194 762 -1432
+ Partials 250 31 -219 ☔ View full report in Codecov by Sentry. |
6 failed tests on run #2854 ↗︎
Details:
classificationsEditor.cy.js • 4 failed tests • Cypress e2e testsaccount.cy.js • 2 failed tests • Cypress e2e tests
Review all test suite changes for PR #2907 ↗︎ |
@cesarvarela done, ready for new review |
@cesarvarela can you review this please? |
cesarvarela
approved these changes
Nov 5, 2024
cesarvarela
merged commit Nov 5, 2024
389f4ac
into
responsible-ai-collaborative:staging
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.