Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display incidents instead of reports for similar/dissimilar incidents #2815

Merged

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Jun 4, 2024

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (291b386) to head (f5d6d69).
Report is 12 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2815      +/-   ##
===========================================
- Coverage    81.50%   81.40%   -0.10%     
===========================================
  Files          155      155              
  Lines        12667    12667              
  Branches      1307     1252      -55     
===========================================
- Hits         10324    10312      -12     
- Misses        2093     2109      +16     
+ Partials       250      246       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clari182
Copy link
Collaborator Author

clari182 commented Jun 5, 2024

Hey @datherton09 , can you take a look at this PR and let me know if the new design for similar/dissimilar looks ok to you?
The test URL is https://pr-2815--staging-aiid.netlify.app/
The changes are

  • It only displays incidents instead of reports when searching by incident ID
  • New tooltip with information on how to use that functionality
  • Some minor design changes
    Let me know what you think. Thanks!!
image

@datherton09
Copy link
Collaborator

@clari182 Nice! Thanks :) Where is the tooltip located?

@clari182
Copy link
Collaborator Author

clari182 commented Jun 6, 2024

@datherton09 the tooltip is located right next to Search similar incident ID

@clari182 clari182 requested a review from pdcp1 September 26, 2024 16:59
Copy link
Collaborator

@pdcp1 pdcp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me now 👍

@cesarvarela
Copy link
Collaborator

@clari182 please merge staging; everything should be ✅

@pdcp1 pdcp1 merged commit 5802bc6 into responsible-ai-collaborative:staging Sep 27, 2024
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants