-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display incidents instead of reports for similar/dissimilar incidents #2815
Display incidents instead of reports for similar/dissimilar incidents #2815
Conversation
clari182
commented
Jun 4, 2024
•
edited
Loading
edited
- closes Improve Similiar and dissimilar incidents edition UX #2799
- Test URL: https://pr-2815--staging-aiid.netlify.app/
- Uses incident autocomplete input to search incident
- Displays one result per incident instead of all its reports
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2815 +/- ##
===========================================
- Coverage 81.50% 81.40% -0.10%
===========================================
Files 155 155
Lines 12667 12667
Branches 1307 1252 -55
===========================================
- Hits 10324 10312 -12
- Misses 2093 2109 +16
+ Partials 250 246 -4 ☔ View full report in Codecov by Sentry. |
Hey @datherton09 , can you take a look at this PR and let me know if the new design for similar/dissimilar looks ok to you?
|
@clari182 Nice! Thanks :) Where is the tooltip located? |
@datherton09 the tooltip is located right next to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me now 👍
@clari182 please merge staging; everything should be ✅ |
5802bc6
into
responsible-ai-collaborative:staging