Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right sidebar content for prismic content #2795

Merged

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented May 21, 2024

In order for the right side Content to work with Prismic rich text, we need to add IDs to headers (h1 and h2) for anchors to work. Since richtext is not Markdown, this needs to be done manually (without any plugins)

Working examples:
https://pr-2795--staging-aiid.netlify.app/blog/incident-report-2024-january/
https://pr-2795--staging-aiid.netlify.app/about/

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (74515a4) to head (5a6d0d0).
Report is 3 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2795      +/-   ##
===========================================
- Coverage    84.13%   84.02%   -0.12%     
===========================================
  Files          164      164              
  Lines        15403    15403              
  Branches      1335     1260      -75     
===========================================
- Hits         12959    12942      -17     
- Misses        2194     2220      +26     
+ Partials       250      241       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented May 21, 2024

Passing run #2478 ↗︎

0 485 248 0 Flakiness 0

Details:

Add right sidebar content for prismic content
Project: aiid-site Commit: 6fc0dacfd8
Status: Passed Duration: 17:50 💡
Started: May 22, 2024 3:04 PM Ended: May 22, 2024 3:22 PM

Review all test suite changes for PR #2795 ↗︎

@cesarvarela cesarvarela merged commit df12e56 into responsible-ai-collaborative:staging Nov 5, 2024
25 of 26 checks passed
@clari182 clari182 deleted the fix/sidebar-anchor branch November 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants