-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global search bar #2792
Add global search bar #2792
Conversation
Passing run #2508 ↗︎
Details:
Review all test suite changes for PR #2792 ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2792 +/- ##
===========================================
+ Coverage 86.19% 86.30% +0.11%
===========================================
Files 248 249 +1
Lines 8415 8419 +4
Branches 2647 2649 +2
===========================================
+ Hits 7253 7266 +13
+ Misses 1078 1068 -10
- Partials 84 85 +1 ☔ View full report in Codecov by Sentry. |
This is very cool. How's it look on mobile? I think I'm not getting the right responsiveness when I activate the menu button -- it doesn't activate under the hover as "clickable" (in the browser) and isn't responding to clicks. |
@kepae Now works with or without hover. If it's in a phone-sized viewport, we just hide it, because if it's already going to be hidden in the menu I figure at the point the user might as well just navigate to the home page or discover page to search. simplescreenrecorder-2024-05-21_12.25.57.mp4 |
…tive/aiid into add-global-search-bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge when ready! And consider taking this as an opportunity to write a "new" playright test?
cd1af6d
into
responsible-ai-collaborative:staging
Resolves #2346.
I put it in the top-right corner, with an expanding icon. That's where I would generally expect to find such a feature. I agree that we might want to rethink the redundant quick action buttons, but I don't think a search bar would look good in their place.
simplescreenrecorder-2024-05-20_14.59.16.mp4