Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global search bar #2792

Merged

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented May 20, 2024

Resolves #2346.

I put it in the top-right corner, with an expanding icon. That's where I would generally expect to find such a feature. I agree that we might want to rethink the redundant quick action buttons, but I don't think a search bar would look good in their place.

simplescreenrecorder-2024-05-20_14.59.16.mp4

Copy link

cypress bot commented May 20, 2024

Passing run #2508 ↗︎

0 485 248 0 Flakiness 0

Details:

Add global search bar
Project: aiid-site Commit: 122917396a
Status: Passed Duration: 16:57 💡
Started: May 27, 2024 3:24 PM Ended: May 27, 2024 3:41 PM

Review all test suite changes for PR #2792 ↗︎

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.30%. Comparing base (8131d30) to head (1229173).
Report is 4 commits behind head on staging.

Files Patch % Lines
site/gatsby-site/src/components/ui/Header.js 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2792      +/-   ##
===========================================
+ Coverage    86.19%   86.30%   +0.11%     
===========================================
  Files          248      249       +1     
  Lines         8415     8419       +4     
  Branches      2647     2649       +2     
===========================================
+ Hits          7253     7266      +13     
+ Misses        1078     1068      -10     
- Partials        84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmcnulty lmcnulty marked this pull request as ready for review May 20, 2024 19:48
@lmcnulty lmcnulty requested review from a team and kepae and removed request for a team May 20, 2024 19:48
@kepae
Copy link
Collaborator

kepae commented May 20, 2024

This is very cool. How's it look on mobile? I think I'm not getting the right responsiveness when I activate the menu button -- it doesn't activate under the hover as "clickable" (in the browser) and isn't responding to clicks.

@lmcnulty
Copy link
Collaborator Author

@kepae Now works with or without hover.

If it's in a phone-sized viewport, we just hide it, because if it's already going to be hidden in the menu I figure at the point the user might as well just navigate to the home page or discover page to search.

simplescreenrecorder-2024-05-21_12.25.57.mp4

Copy link
Collaborator

@kepae kepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready! And consider taking this as an opportunity to write a "new" playright test?

@lmcnulty lmcnulty merged commit cd1af6d into responsible-ai-collaborative:staging Jun 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants