-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table view report links #2756
Fix table view report links #2756
Conversation
Passing run #2489 ↗︎
Details:
Review all test suite changes for PR #2756 ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2756 +/- ##
===========================================
+ Coverage 85.99% 86.15% +0.16%
===========================================
Files 251 248 -3
Lines 8402 8415 +13
Branches 2642 2650 +8
===========================================
+ Hits 7225 7250 +25
+ Misses 1092 1081 -11
+ Partials 85 84 -1 ☔ View full report in Codecov by Sentry. |
@clari182 During my testing of https://pr-2756--staging-aiid.netlify.app/apps/incidents/?view=reports I realized that we have some timeout errors
@cesarvarela Is this something related to the API changes? Or is this only happeninginn the Staging environment? |
8131d30
into
responsible-ai-collaborative:staging
/report/*
, regardless of incident associations #2229The original idea was to have the report page for all reports. But this is not possible due to the quantity of pages generated, the build fails because of insufficient space.
So, the fix here instead is when viewing reports on the table view (https://pr-2756--staging-aiid.netlify.app/apps/incidents/?view=reports) the report links to the cite page of that report.