Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table view report links #2756

Merged

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Apr 25, 2024

The original idea was to have the report page for all reports. But this is not possible due to the quantity of pages generated, the build fails because of insufficient space.

So, the fix here instead is when viewing reports on the table view (https://pr-2756--staging-aiid.netlify.app/apps/incidents/?view=reports) the report links to the cite page of that report.

Copy link

cypress bot commented Apr 29, 2024

Passing run #2489 ↗︎

0 485 248 0 Flakiness 0

Details:

Fix table view report links
Project: aiid-site Commit: 9b9492802a
Status: Passed Duration: 15:46 💡
Started: May 23, 2024 3:43 PM Ended: May 23, 2024 3:59 PM

Review all test suite changes for PR #2756 ↗︎

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 86.15%. Comparing base (a5ddcaa) to head (9b94928).

Files Patch % Lines
site/gatsby-site/src/pages/apps/incidents.js 64.00% 8 Missing and 1 partial ⚠️
site/gatsby-site/src/templates/report.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2756      +/-   ##
===========================================
+ Coverage    85.99%   86.15%   +0.16%     
===========================================
  Files          251      248       -3     
  Lines         8402     8415      +13     
  Branches      2642     2650       +8     
===========================================
+ Hits          7225     7250      +25     
+ Misses        1092     1081      -11     
+ Partials        85       84       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clari182 clari182 marked this pull request as ready for review May 22, 2024 14:17
@clari182 clari182 requested a review from pdcp1 May 22, 2024 14:19
@clari182 clari182 changed the title Report page for all reports Fix table view report links May 22, 2024
@pdcp1
Copy link
Collaborator

pdcp1 commented May 22, 2024

@clari182 During my testing of https://pr-2756--staging-aiid.netlify.app/apps/incidents/?view=reports I realized that we have some timeout errors 502 502 Bad Gateway on each /graphql call to retrieve the Live version of reports and Live version of incidents.

{"errorType":"LambdaTimeout","errorMessage":"2024-05-22T19:10:14.718Z afdded9a-fa1b-47d9-b13c-03372618773c Task timed out after 10.01 seconds"}

@cesarvarela Is this something related to the API changes? Or is this only happeninginn the Staging environment?

@pdcp1 pdcp1 merged commit 8131d30 into responsible-ai-collaborative:staging May 24, 2024
9 of 10 checks passed
@clari182 clari182 deleted the feature/report-page branch May 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants