-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GMF Taxonomy #2749
Merged
lmcnulty
merged 6 commits into
responsible-ai-collaborative:staging
from
lmcnulty:2024-04_update-gmf-taxonomy
Apr 30, 2024
Merged
Update GMF Taxonomy #2749
lmcnulty
merged 6 commits into
responsible-ai-collaborative:staging
from
lmcnulty:2024-04_update-gmf-taxonomy
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2749 +/- ##
===========================================
- Coverage 77.21% 76.45% -0.76%
===========================================
Files 211 248 +37
Lines 6710 8351 +1641
Branches 2150 2626 +476
===========================================
+ Hits 5181 6385 +1204
- Misses 1363 1750 +387
- Partials 166 216 +50 ☔ View full report in Codecov by Sentry. |
8 failed tests on run #2194 ↗︎
Details:
cypress/e2e/integration/citeEdit.cy.js • 8 failed tests • Cypress e2e testsReview all test suite changes for PR #2749 ↗︎ |
kepae
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merge to staging when you're ready.
lmcnulty
merged commit Apr 30, 2024
19e11c4
into
responsible-ai-collaborative:staging
7 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #2496.
Checks in GMF description as markdown file, first step of #2677.
Also includes updates to taxonomy page rendering.
Images are visible:
Footnotes render correctly: