Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GMF Taxonomy #2749

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented Apr 24, 2024

Per #2496.

Checks in GMF description as markdown file, first step of #2677.

Also includes updates to taxonomy page rendering.

Images are visible:

image

Footnotes render correctly:

image

@lmcnulty lmcnulty marked this pull request as ready for review April 24, 2024 20:39
@lmcnulty lmcnulty requested review from a team and kepae and removed request for a team April 24, 2024 20:39
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.45%. Comparing base (af6aa77) to head (0d0b693).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2749      +/-   ##
===========================================
- Coverage    77.21%   76.45%   -0.76%     
===========================================
  Files          211      248      +37     
  Lines         6710     8351    +1641     
  Branches      2150     2626     +476     
===========================================
+ Hits          5181     6385    +1204     
- Misses        1363     1750     +387     
- Partials       166      216      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kepae kepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge to staging when you're ready.

@lmcnulty lmcnulty merged commit 19e11c4 into responsible-ai-collaborative:staging Apr 30, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants