Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dummy translations #2734

Merged

Conversation

cesarvarela
Copy link
Collaborator

@cesarvarela cesarvarela commented Apr 16, 2024

Closes #2701

Result from current production DB:

Deleted 0 dummy translations for en
Deleted 202 dummy translations for es
Deleted 202 dummy translations for fr
Deleted 63 dummy translations for ja

TRANSLATE_DRY_RUN needs to be set explicitly to false

@kepae
Copy link
Collaborator

kepae commented Apr 16, 2024

I've TRANSLATE_DRY_RUN to true in production as well as now that we have the date lookback protection:
#2699

image

@kepae
Copy link
Collaborator

kepae commented Apr 16, 2024

Ah! Actually disabling the dry run flag in staging. Important.
image

Copy link

cypress bot commented Apr 16, 2024

Passing run #2118 ↗︎

0 480 244 0 Flakiness 0

Details:

Delete dummy translations
Project: aiid-site Commit: bdf947707f
Status: Passed Duration: 16:32 💡
Started: Apr 16, 2024 8:38 PM Ended: Apr 16, 2024 8:54 PM

Review all test suite changes for PR #2734 ↗︎

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (b8348cc) to head (bdf9477).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2734      +/-   ##
===========================================
+ Coverage    86.29%   86.41%   +0.11%     
===========================================
  Files          248      248              
  Lines         8338     8338              
  Branches      2627     2628       +1     
===========================================
+ Hits          7195     7205      +10     
+ Misses        1050     1040      -10     
  Partials        93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kepae kepae merged commit 8b959d8 into responsible-ai-collaborative:staging Apr 17, 2024
10 checks passed
@kepae kepae mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants