Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/discover link break #2537

Merged

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Jan 9, 2024

  1. Go to Discover
  2. Switch to list view
  3. Click on a result

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for staging-aiid ready!

Name Link
🔨 Latest commit b3e9242
🔍 Latest deploy log https://app.netlify.com/sites/staging-aiid/deploys/659d81029be32c0008fd229d
😎 Deploy Preview https://deploy-preview-2537--staging-aiid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 9, 2024

3 failed tests on run #1620 ↗︎

3 329 183 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Fix/discover link break
Project: aiid-site Commit: 5cafae64c6
Status: Failed Duration: 52:32 💡
Started: Feb 12, 2024 8:01 PM Ended: Feb 12, 2024 8:54 PM

Review all test suite changes for PR #2537 ↗︎

@clari182
Copy link
Collaborator Author

Ready for another review @pdcp1 , I also fixed the display type not being persisted in the URL on reload

@kepae kepae merged commit f63174d into responsible-ai-collaborative:staging Feb 16, 2024
6 of 8 checks passed
@clari182 clari182 deleted the fix/discover-link-break branch February 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants