Remove MONGODB_HOST environment variable from backup scripts

responsible-ai-collaborative · Aug 20, 2024 · 9e9fbd2 · 9e9fbd2
1 parent 87b8af6
commit 9e9fbd2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 5 deletions.
diff --git a/.github/workflows/db-backup-private.yml b/.github/workflows/db-backup-private.yml
@@ -60,7 +60,6 @@ jobs:
             -e CLOUDFLARE_R2_WRITE_SECRET_ACCESS_KEY="${{ secrets.CLOUDFLARE_R2_WRITE_SECRET_ACCESS_KEY }}" \
             -e CLOUDFLARE_R2_BUCKET_NAME="${{ vars.CLOUDFLARE_R2_BUCKET_NAME }}" \
             -e BACKUPFILE_PREFIX="backup" \
-            -e MONGODB_HOST="mongo" \
             -e MONGODB_URI="mongodb+srv://${{ secrets.MONGO_BACKUP_USER }}:${{ secrets.MONGO_BACKUP_USER_PASSWORD }}@aiiddev-aqdmh.gcp.mongodb.net/aiidprod" \
             -e MONGODB_DBNAME="aiidprod" \
             -e MONGODB_URI_TRANSLATIONS="mongodb+srv://${{ secrets.MONGO_BACKUP_USER }}:${{ secrets.MONGO_BACKUP_USER_PASSWORD }}@aiiddev-aqdmh.gcp.mongodb.net/translations" \

diff --git a/.github/workflows/db-backup-public.yml b/.github/workflows/db-backup-public.yml
@@ -60,7 +60,6 @@ jobs:
             -e CLOUDFLARE_R2_WRITE_SECRET_ACCESS_KEY="${{ secrets.CLOUDFLARE_R2_WRITE_SECRET_ACCESS_KEY }}" \
             -e CLOUDFLARE_R2_BUCKET_NAME="${{ vars.CLOUDFLARE_R2_BUCKET_NAME }}" \
             -e BACKUPFILE_PREFIX="backup" \
-            -e MONGODB_HOST="mongo" \
             -e MONGODB_URI="${{ secrets.MONGODB_CONNECTION_STRING }}" \
             -e MONGODB_DBNAME="aiidprod" \
             -e MONGODB_DBNAME_TRANSLATIONS="translations" \

diff --git a/docker-db-backup/README.md b/docker-db-backup/README.md
@@ -31,7 +31,6 @@ docker run --rm \
   -e CLOUDFLARE_R2_BUCKET_NAME=<Cloudflare R2 bucket name (ie: "aiid-public")> \
   [ -e BACKUPFILE_PREFIX=<Prefix of Backup Filename (default: "backup") \ ]
   [ -e MONGODB_URI=<Target MongoDB URI> \ ]
-  [ -e MONGODB_HOST=<Target MongoDB Host (default: "mongo")> \ ]
   [ -e MONGODB_DBNAME=<Target DB name> \ ]
   [ -e MONGODB_USERNAME=<DB login username> \ ]
   [ -e MONGODB_PASSWORD=<DB login password> \ ]
@@ -68,7 +67,6 @@ Environment variables
 | --------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
 | BACKUPFILE_PREFIX                 | Prefix of Backup Filename                                                                                                                                                                                 | "backup" |
 | MONGODB_URI                       | Target MongoDB URI (ex. `mongodb://mongodb?replicaSet=rs0`). If set, the other `MONGODB_*` variables will be ignored.                                                                                     | -        |
-| MONGODB_HOST                      | Target MongoDB Host                                                                                                                                                                                       | "mongo"  |
 | MONGODB_DBNAME                    | Target DB name                                                                                                                                                                                            | -        |
 | MONGODB_USERNAME                  | DB login username                                                                                                                                                                                         | -        |
 | MONGODB_PASSWORD                  | DB login password                                                                                                                                                                                         | -        |

diff --git a/docker-db-backup/bin/backup.sh b/docker-db-backup/bin/backup.sh
@@ -5,7 +5,6 @@ echo "Starting backup.sh script execution..."
 # settings
 IS_PUBLIC_BACKUP=${IS_PUBLIC_BACKUP:-false}
 BACKUPFILE_PREFIX=${BACKUPFILE_PREFIX:-backup}
-MONGODB_HOST=${MONGODB_HOST:-mongo}
 CRONMODE=${CRONMODE:-false}
 CLOUDFLARE_R2_ACCOUNT_ID=${CLOUDFLARE_R2_ACCOUNT_ID}
 if [ "${IS_PUBLIC_BACKUP}" == "true" ]; then