Refactor SORTING_LIST creation to use map instead of forEach for impr…

…oved readability
responsible-ai-collaborative · Dec 12, 2024 · 34b8401 · 34b8401
1 parent c815d83
commit 34b8401
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/site/gatsby-site/src/components/discover/SORTING_LISTS.js b/site/gatsby-site/src/components/discover/SORTING_LISTS.js
@@ -63,9 +63,7 @@ const BASE_SORTING_LIST = [
   },
 ];
 
-const SORTING_LIST = [];
-
-BASE_SORTING_LIST.forEach((item) => {
+const SORTING_LIST = BASE_SORTING_LIST.map((item) => {
   const newItem = {
     ...item,
     value: `instant_search-en${item.instantKey == 'featured' ? '-' : '_'}${item.instantKey}`,
@@ -80,7 +78,7 @@ BASE_SORTING_LIST.forEach((item) => {
   // remove auxiliary field
   delete newItem.instantKey;
 
-  SORTING_LIST.push(newItem);
+  return newItem;
 });
 
 export default SORTING_LIST;