Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: uniformize detailed views #366

Open
wants to merge 1 commit into
base: angular-17
Choose a base branch
from

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 17, 2024

No description provided.

@jma jma force-pushed the maj-prime-detailed-view branch 2 times, most recently from a3b4619 to f41d920 Compare July 24, 2024 08:17
* Removes useless detailed views.
* Redirects to the search view after record edition.
* Uses short editor when it is possible.
* Uses a generic component to display fields in detailed views.
* Removes useless test files.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-prime-detailed-view branch from f41d920 to 28b4283 Compare July 24, 2024 08:19
@jma jma marked this pull request as ready for review August 27, 2024 14:25
</dd>
<sonar-field-description [label]="'Is shared' | translate" [field]="record.metadata.isShared">
<ng-template let-isShared pTemplate="template">
<i class="fa fa-{{ isShared ? 'check' : 'close' }}"></i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<i class="fa" [ngClass]="{ 'fa-check': isShared, 'fa-close': !isShared }"></i>

</dd>
<sonar-field-description [label]="'Is dedicated' | translate" [field]="record.metadata.isDedicated">
<ng-template let-isDedicated pTemplate="template">
<i class="fa fa-{{ isDedicated ? 'check' : 'close' }}"></i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

</ng-container>
<i class="fa fa-{{ record.metadata['documentsCustomField' + i].includeInFacets ? 'check' : 'remove' }}"></i>
}
<i class="fa fa-{{ customField.includeInFacets ? 'check' : 'remove' }}"></i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<i class="fa" [ngClass]="{ 'fa-check': customField.includeInFacets, 'fa-remove': !customField.includeInFacets }"></i>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants