Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: fix import SLSP #3460

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Sep 14, 2023

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@rerowep rerowep self-assigned this Sep 14, 2023
@github-actions github-actions bot added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Sep 14, 2023
@rerowep rerowep force-pushed the wep-#2746-fix-import_SLSP branch from 555e9d6 to 49932bd Compare September 14, 2023 13:43
@rerowep rerowep force-pushed the wep-#2746-fix-import_SLSP branch 2 times, most recently from 3f8361e to 23168d7 Compare October 2, 2023 13:42
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing.

@rerowep rerowep force-pushed the wep-#2746-fix-import_SLSP branch 4 times, most recently from 76ebe6c to 7cfecf5 Compare October 3, 2023 12:57
@rerowep rerowep marked this pull request as draft October 3, 2023 13:05
@rerowep rerowep force-pushed the wep-#2746-fix-import_SLSP branch 3 times, most recently from 8b4605d to 084bf40 Compare October 3, 2023 18:04
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#2746-fix-import_SLSP branch from 084bf40 to 097d88b Compare October 3, 2023 19:49
@rerowep rerowep marked this pull request as ready for review October 3, 2023 20:46
@rerowep rerowep merged commit cecd63a into rero:staging Oct 9, 2023
@rerowep rerowep deleted the wep-#2746-fix-import_SLSP branch October 9, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document import: subject creator is unexpected
4 participants