stats: add tests

* Splits the classes to compute statistics into several files.
* Fixes some spelling.
* Renames abstract class which is not abstract.
* Removes useless parameters in the statics methods.
* Get the location names using only one es query.
* Creates a loan search query used for several statistics.
* Fixes delete items statistics.
* Adds tests for statistics.
* Fixes some test fixtures.
* Adds a type filter to the operation logs search to avoid unwanted documents.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>

pyproject.toml

@@ -329,7 +329,7 @@ patron_id = "rero_ils.modules.patrons.api:patron_id_fetcher"
 patron_transaction_event_id = "rero_ils.modules.patron_transaction_events.api:patron_transaction_event_id_fetcher"
 patron_transaction_id = "rero_ils.modules.patron_transactions.api:patron_transaction_id_fetcher"
 patron_type_id = "rero_ils.modules.patron_types.api:patron_type_id_fetcher"
-stat_id = "rero_ils.modules.stats.api:stat_id_fetcher"
+stat_id = "rero_ils.modules.stats.api.api:stat_id_fetcher"
 template_id = "rero_ils.modules.templates.api:template_id_fetcher"
 entity_id = "rero_ils.modules.entities.fetchers:id_fetcher"
 vendor_id = "rero_ils.modules.vendors.api:vendor_id_fetcher"
@@ -360,7 +360,7 @@ patron_id = "rero_ils.modules.patrons.api:patron_id_minter"
 patron_transaction_event_id = "rero_ils.modules.patron_transaction_events.api:patron_transaction_event_id_minter"
 patron_transaction_id = "rero_ils.modules.patron_transactions.api:patron_transaction_id_minter"
 patron_type_id = "rero_ils.modules.patron_types.api:patron_type_id_minter"
-stat_id = "rero_ils.modules.stats.api:stat_id_minter"
+stat_id = "rero_ils.modules.stats.api.api:stat_id_minter"
 template_id = "rero_ils.modules.templates.api:template_id_minter"
 entity_id = "rero_ils.modules.entities.minters:id_minter"
 vendor_id = "rero_ils.modules.vendors.api:vendor_id_minter"

rero_ils/config.py

@@ -127,7 +127,7 @@
 from .modules.patrons.models import CommunicationChannel
 from .modules.patrons.permissions import PatronPermissionPolicy
 from .modules.selfcheck.permissions import seflcheck_permission_factory
-from .modules.stats.api import Stat
+from .modules.stats.api.api import Stat
 from .modules.stats.permissions import StatisticsPermissionPolicy
 from .modules.templates.permissions import TemplatePermissionPolicy
 from .modules.users.api import get_profile_countries, \
@@ -773,9 +773,9 @@ def _(x):
         pid_type='stat',
         pid_minter='stat_id',
         pid_fetcher='stat_id',
-        search_class='rero_ils.modules.stats.api:StatsSearch',
+        search_class='rero_ils.modules.stats.api.api:StatsSearch',
         search_index='stats',
-        indexer_class='rero_ils.modules.stats.api:StatsIndexer',
+        indexer_class='rero_ils.modules.stats.api.api:StatsIndexer',
         search_type=None,
         record_serializers={
             'application/json': 'rero_ils.modules.serializers:json_v1_response',
@@ -792,8 +792,8 @@ def _(x):
         record_loaders={
             'application/json': lambda: Stat(request.get_json()),
         },
-        record_class='rero_ils.modules.stats.api:Stat',
-        item_route='/stats/<pid(stat, record_class="rero_ils.modules.stats.api:Stat"):pid_value>',
+        record_class='rero_ils.modules.stats.api.api:Stat',
+        item_route='/stats/<pid(stat, record_class="rero_ils.modules.stats.api.api:Stat"):pid_value>',
         default_media_type='application/json',
         max_result_window=MAX_RESULT_WINDOW,
         list_permission_factory_imp=lambda record: StatisticsPermissionPolicy('search', record=record),
@@ -2829,7 +2829,7 @@ def _(x):
         pid_type='stat',
         route='/stats/<pid_value>',
         template='rero_ils/detailed_view_stats.html',
-        record_class='rero_ils.modules.stats.api:Stat',
+        record_class='rero_ils.modules.stats.api.api:Stat',
         view_imp='rero_ils.modules.stats.views.stats_view_method',
         permission_factory_imp='rero_ils.modules.stats.permissions:stats_ui_permission_factory',
     )
@@ -2897,7 +2897,7 @@ def _(x):
 # Statistics Configuration
 # ========================
 # Compute the stats with a timeframe given in monthes
-RERO_ILS_STATS_BILLING_TIMEFRAME_IN_MONTHES = 3
+RERO_ILS_STATS_BILLING_TIMEFRAME_IN_MONTHS = 3
 
 
 # =============================================================================

rero_ils/modules/loans/logs/api.py

@@ -19,14 +19,14 @@
 
 from invenio_search import RecordsSearch
 
-from rero_ils.modules.operation_logs.logs.api import \
-    AbstractSpecificOperationLog
+from rero_ils.modules.operation_logs.api import OperationLog
+from rero_ils.modules.operation_logs.logs.api import SpecificOperationLog
 
 from ...items.api import Item
 from ...patrons.api import Patron, current_librarian
 
 
-class LoanOperationLog(AbstractSpecificOperationLog):
+class LoanOperationLog(OperationLog, SpecificOperationLog):
     """Operation log for loans."""
 
     @classmethod

rero_ils/modules/notifications/logs/api.py

@@ -18,13 +18,13 @@
 
 """Notification logs API."""
 
-from rero_ils.modules.operation_logs.logs.api import \
-    AbstractSpecificOperationLog
+from rero_ils.modules.operation_logs.api import OperationLog
+from rero_ils.modules.operation_logs.logs.api import SpecificOperationLog
 
 from ..models import RecipientType
 
 
-class NotificationOperationLog(AbstractSpecificOperationLog):
+class NotificationOperationLog(OperationLog, SpecificOperationLog):
     """Operation log for notification."""
 
     @classmethod

rero_ils/modules/operation_logs/logs/api.py

@@ -21,12 +21,11 @@
 import hashlib
 
 from rero_ils.modules.locations.api import Location
-from rero_ils.modules.operation_logs.api import OperationLog
 from rero_ils.modules.utils import extracted_data_from_ref
 
 
-class AbstractSpecificOperationLog(OperationLog):
-    """Abstract Specific Operation log."""
+class SpecificOperationLog():
+    """Specific Operation log."""
 
     @classmethod
     def _get_patron_data(cls, patron):