Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patron: fix display of optional address fields #1056

Merged
merged 1 commit into from
Oct 31, 2023
Merged

patron: fix display of optional address fields #1056

merged 1 commit into from
Oct 31, 2023

Conversation

Garfield-fr
Copy link
Contributor

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr self-assigned this Oct 10, 2023
@github-actions github-actions bot added the f: professional ui Professional interface label Oct 10, 2023
@Garfield-fr Garfield-fr force-pushed the zub-patron-address-fix branch from 252f05a to 0321dd2 Compare October 10, 2023 09:22
@Garfield-fr Garfield-fr changed the title patron: fix display of optional address field patron: fix display of optional address fields Oct 10, 2023
@PascalRepond
Copy link
Contributor

PascalRepond commented Oct 26, 2023 •
edited
Loading

Tests

  • REP [not blocking and PROBABLY NOT LINKED TO THIS PR]: When a patron has no main address AND no secondary address, the country of the main address is saved into second_address.country

@Garfield-fr Garfield-fr merged commit 397ff1b into rero:staging Oct 31, 2023
3 checks passed
@PascalRepond PascalRepond added the bug Breaks something, but is not blocking. label Nov 9, 2023
@Garfield-fr Garfield-fr deleted the zub-patron-address-fix branch December 11, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@lauren-d lauren-d lauren-d approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something, but is not blocking. f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @PascalRepond @jma @zannkukai @lauren-d