This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
Convert Heroku environment variable to a proper boolean value before … #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initializing. Resolves #229.
|
Hello, I was reviewing your changes and I saw that originally the code said:
However your changes use the following name for the env. variable: The env. variable name is different: underscore (_) missing after WIKI. Just wanted to verify that this is not a typo ;) |
|
Good catch - that was a typo. Pretty sure I copied it out of the wrong container (I was working in two). Will update as soon as I get back to my computer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces the
WIKIJS_HEROKUenvironment variable into a boolean state. Resolves #229.