Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Docker Container Fails to Start #229

Open
coreybutler opened this issue Aug 1, 2019 · 1 comment · May be fixed by #230
Open

Docker Container Fails to Start #229

coreybutler opened this issue Aug 1, 2019 · 1 comment · May be fixed by #230

Comments

@coreybutler
Copy link

coreybutler commented Aug 1, 2019

Actual behavior

The container doesn't start on Docker for macOS/Windows.

Expected behavior

The container should run.

Steps to reproduce the behavior

Setup a new container using Docker for macOS/Windows.


This is basically the same as issue #224.

The problem has to do with an invalid environment variable check at https://github.com/Requarks/wiki-v1/blob/master/server/init.js#L16. By default, the environment variable is 1, which is incorrect. When setting this to 0 in Docker for macOS/Windows, it still fails because the process.env.WIKI_JS_HEROKU variable is a string, not a boolean. Passing in true or false also yields the wrong result because Docker will always receive environment variables as strings, so the if/else check will always evaluate to true.

image

image

This results in the following output in Docker for macOS:

image

@coreybutler
Copy link
Author

With PR #230 applied, the app starts as expected.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant