Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keycloak guide #28

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Add Keycloak guide #28

merged 2 commits into from
Sep 16, 2021

Conversation

Sherex
Copy link
Contributor

@Sherex Sherex commented Sep 15, 2021

Hello,

I created this guide for Keycloak a while ago (I didn't realise there was a docs repo) and posted it as a gist here and on the feature tracker.

I added the image tag at the bottom for a Keycloak logo pointing to https://static.requarks.io/logo/keycloak.svg, let me know if I should remove it. :)

@chikamichi
Copy link

Terrific! I'd suggest adding a link to the guide though, maybe on https://github.com/Requarks/wiki-docs/blob/master/auth.md 🤷 (there is this unlinked Generic OpenID / Oauth2 item in the Modules list, which could be a good candidate; or adding an item altogether such as Keycloak OpenID Connect).

@Sherex
Copy link
Contributor Author

Sherex commented Sep 16, 2021

Ah that's probably smart :P

I added it as it's own section as there are some very specific points that are for Keycloak.
But I created a generic one too here: #30

Let me know if something should be changed :)

@chikamichi
Copy link

Hopefully NGPixel will come by and validate some pending PR soon (or delegate to someone else?) :)

@NGPixel NGPixel merged commit 7b666b8 into requarks:master Sep 16, 2021
@chikamichi
Copy link

Thanks! Both of you :) 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants