Fix some warnings

reportportal · Feb 21, 2024 · ad36741 · ad36741
1 parent 3350a3e
commit ad36741
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/com/epam/reportportal/util/test/ProcessUtils.java b/src/main/java/com/epam/reportportal/util/test/ProcessUtils.java
@@ -26,6 +26,7 @@
 import javax.annotation.Nullable;
 import java.io.*;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.FileSystems;
 import java.util.*;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Predicate;
@@ -52,7 +53,7 @@ private static String getPathToClass(@Nonnull Class<?> mainClass) {
 	public static Process buildProcess(boolean inheritOutput, @Nonnull Class<?> mainClass,
 			@Nullable Map<String, String> additionalEnvironmentVariables,
 			@Nullable Map<String, String> additionSystemVariables, String... params) throws IOException {
-		String fileSeparator = System.getProperty("file.separator");
+		String fileSeparator = FileSystems.getDefault().getSeparator();
 		String javaHome = System.getProperty("java.home");
 		String executablePath = joinWith(fileSeparator, javaHome, "bin", "java");
 		File executableFile = new File(executablePath);
@@ -136,7 +137,7 @@ public static String waitForLine(final BufferedReader reader, final BufferedRead
 			if (errorReader.ready()) {
 				errorLines = IOUtils.readLines(errorReader);
 			}
-			String lineSeparator = System.getProperty("line.separator");
+			String lineSeparator = System.lineSeparator();
 			throw new IllegalStateException("Unable to run test class: " + String.join(lineSeparator, errorLines));
 		}
 	}

diff --git a/src/main/java/com/epam/reportportal/util/test/SocketUtils.java b/src/main/java/com/epam/reportportal/util/test/SocketUtils.java
@@ -67,7 +67,7 @@ public List<String> call() throws Exception {
 				StringBuilder builder = new StringBuilder();
 				String line;
 				while ((line = in.readLine()) != null) {
-					if (line.equals("")) {
+					if (line.isEmpty()) {
 						break;
 					}
 					builder.append(line);