Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multiple nodes analyzers #1667

Merged
merged 24 commits into from
Nov 4, 2024
Merged

feat: multiple nodes analyzers #1667

merged 24 commits into from
Nov 4, 2024

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Oct 30, 2024 •
edited
Loading

Description, Motivation and Context

Follow reference implementation from #1646

Story: https://app.shortcut.com/replicated/story/114089/update-host-analyzers-to-support-analysis-on-collected-contents-from-remote-hosts

Demo: https://www.loom.com/share/282734773f98418ab5fefb317fd7be4e?sid=c5b91fda-adac-45de-9ed2-a6f05fadb536

List of analyzers

Analyzer Active
blockDevices ✓
diskUsage ✓
filesystemPerformance ✓
certificate ✓
http ✓
httpLoadBalancer ✓
ipv4Interfaces ✓
subnetAvailable ✓
tcpConnect ✓
tcpLoadBalancer ✓
tcpPortStatus ✓
udpPortStatus ✓
hostServices ✓
kernelConfigs ✓
time ✓
systemPackages ✓

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@nvanthao nvanthao added the type::feature New feature or request label Oct 30, 2024
@nvanthao nvanthao requested a review from a team as a code owner October 30, 2024 03:09
@nvanthao nvanthao force-pushed the gerard/sc-114089/remote-host-analyzers branch from aaf3d2c to 9226a05 Compare October 30, 2024 03:26
@nvanthao nvanthao marked this pull request as draft October 30, 2024 03:33
@nvanthao nvanthao marked this pull request as ready for review October 30, 2024 05:28
@nvanthao nvanthao force-pushed the gerard/sc-114089/remote-host-analyzers branch from 5c8d270 to 637479b Compare October 30, 2024 22:36
@nvanthao nvanthao force-pushed the gerard/sc-114089/remote-host-analyzers branch from 8d35929 to 03d953f Compare October 31, 2024 01:47
diamonwiggins
diamonwiggins approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvanthao nvanthao merged commit f0b8de6 into main Nov 4, 2024
27 checks passed
@nvanthao nvanthao deleted the gerard/sc-114089/remote-host-analyzers branch November 4, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamonwiggins diamonwiggins diamonwiggins approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvanthao @diamonwiggins