Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove preempted deprecation warnings #1655

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: Remove preempted deprecation warnings #1655

merged 1 commit into from
Oct 21, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Oct 21, 2024 •
edited
Loading

Description, Motivation and Context

Remove deprecation warnings directing people to us loader.LoadSpecs. The APIs we mark deprecated do not have a loader.LoadSpecs replacement

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@banjoh banjoh requested a review from a team as a code owner October 21, 2024 17:29
nvanthao
nvanthao approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvanthao nvanthao merged commit 9c24ab6 into replicatedhq:main Oct 21, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanthao nvanthao nvanthao approved these changes

Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banjoh @nvanthao