Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix nil check in host collector filter #1653

Merged
merged 3 commits into from
Oct 18, 2024
Merged

bug: fix nil check in host collector filter #1653

merged 3 commits into from
Oct 18, 2024

Conversation

nvanthao
Copy link
Member

Description, Motivation and Context

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@nvanthao nvanthao requested a review from a team as a code owner October 18, 2024 01:45
@nvanthao nvanthao requested a review from DexterYan October 18, 2024 04:22
@nvanthao nvanthao added the type::bug Something isn't working label Oct 18, 2024
@nvanthao nvanthao merged commit 289102f into main Oct 18, 2024
27 checks passed
@nvanthao nvanthao deleted the gerard/b-nil-host-collector branch October 18, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DexterYan DexterYan DexterYan approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvanthao @DexterYan