Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(make): make sure github action can check schemas change #1651

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Oct 15, 2024

Description, Motivation and Context

  • fix ensure-schemas-are-generated task not detect schema change by git status --short
  • change to dynamic path --output-base=$$(pwd)/../../../ \

Here is an example.
current non-working one https://github.com/replicatedhq/troubleshoot/actions/runs/11336833376/job/31527432789?pr=1648#step:7:76
you can find that result of git status -short was not picked by github action.

In fixed one https://github.com/replicatedhq/troubleshoot/actions/runs/11355501407/job/31584952502?pr=1648

it has been picked up.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan added type::bug Something isn't working bug::normal labels Oct 15, 2024
@DexterYan DexterYan self-assigned this Oct 15, 2024
@DexterYan DexterYan requested a review from a team as a code owner October 15, 2024 01:50
@DexterYan DexterYan removed their assignment Oct 15, 2024
@DexterYan DexterYan merged commit 77fd7da into main Oct 16, 2024
27 checks passed
@DexterYan DexterYan deleted the dx/sc-113772/fix-check-scheme-fail branch October 16, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants