-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optionally save preflight bundles to disk #1612
feat: Optionally save preflight bundles to disk #1612
Conversation
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Docs PR replicatedhq/troubleshoot.sh#578 |
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
55484be
to
b831eea
Compare
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
As for your question, the tarball is always saved to disk
It saves it on both cases. I made a change to always log when its saved to disk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description, Motivation and Context
This PR introduces a way to store a bundle of collected data when running preflights. The changes are
preflight
command. The format ispreflightbundle-YYYY-MM-DDTHH_MM_SS.tar.gz
BundlePath
option for SDK users to pass in a bundle path to store collected preflight data in that directory.Demo: https://asciinema.org/a/NBz1y7erRhATItuFR0F8N6tMr
Fixes: sc-111576
Checklist
Does this PR introduce a breaking change?