feat: sonobuoy collector #1469
Merged
feat: sonobuoy collector #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
force-pushed
the
feat-sonobuoy-collector
branch
from
04c592d to
eb7bde4
Compare
banjoh
approved these changes
Feb 14, 2024
| ec := make(chan error, 1) | ||
|
|
||
| restClient := client.CoreV1().RESTClient() | ||
| req := restClient.Post(). |
There was a problem hiding this comment.
Nit: Could you log the command being run? When testing this I couldn't get results so wanted to test using kubectl. Grabbing the parameters from logs would be nice
Some high level logs like "results were collected", "could not collect anything... "...
There was a problem hiding this comment.
Added
Collecting support bundle ⠙ sonobuoyI0215 06:46:55.370095 50799 sonobuoy_results.go:132] Sonobuoy collector runing command: kubectl exec -n sonobuoy sonobuoy -c kube-sonobuoy -- /sonobuoy splat /tmp/sonobuoy
Collecting support bundle ⠼ sonobuoyI0215 06:46:56.623800 50799 sonobuoy_results.go:99] Sonobuoy collector found file: 202402151442_sonobuoy_ca07019f-7be9-4c54-9449-e1611c7cc5a8.tar.gz
banjoh
reviewed
Feb 14, 2024
You will first have to run sonobuoy in your cluster |
emosbaugh
force-pushed
the
feat-sonobuoy-collector
branch
from
a7a9995 to
7e6bc39
Compare
banjoh
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Retrieve sonobuoy results from the cluster and store them in the bundle. An analyzer would be beneficial as a follow up.
replicatedhq/troubleshoot.sh#547
Checklist
Does this PR introduce a breaking change?