Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle unreachable URIs in loadSupportBundleSpecsFromURIs #1383

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Gracefully handle unreachable URIs in loadSupportBundleSpecsFromURIs #1383

merged 4 commits into from
Oct 27, 2023

Conversation

diamonwiggins
Copy link
Member

Description, Motivation and Context

  • If a support bundle URI cannot be reached or fails to load, the function logs a warning and continues to the next URI, instead of returning an error. This is to implicitly support air-gapped environments where external URIs might be inaccessible.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@diamonwiggins diamonwiggins requested a review from a team as a code owner October 26, 2023 20:47
@diamonwiggins diamonwiggins linked an issue Oct 26, 2023 that may be closed by this pull request
uri fails to fallback under some circumstances #1382
Closed
@diamonwiggins diamonwiggins requested a review from banjoh October 26, 2023 21:09
@diamonwiggins diamonwiggins added type::bug Something isn't working bug::regression labels Oct 26, 2023
banjoh
banjoh approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. I added a test for this regression

@banjoh banjoh merged commit 08c3fcf into main Oct 27, 2023
23 checks passed
@banjoh banjoh deleted the fix/load-specs-nil-on-unreachable-uri branch October 27, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

@DexterYan DexterYan Awaiting requested review from DexterYan

Assignees
No one assigned
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uri fails to fallback under some circumstances
2 participants
@diamonwiggins @banjoh