Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow warning when filesystem performance not collected (fio) #1363

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

laverya
Copy link
Member

@laverya laverya commented Oct 10, 2023

Description, Motivation and Context

The host filesystem performance collector now relies on an external binary fio. This is not always present, and when it is not present the collector will not produce a file.

There should be a way to say "this is not a failure" in the analysis when this file is missing.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. link

Does this PR introduce a breaking change?

  • Yes
  • No

@laverya laverya requested a review from a team as a code owner October 10, 2023 14:34
@laverya laverya changed the title Laverya/allow warning when file not collected fio allow warning when filesystem performance not collected (fio) Oct 10, 2023
@laverya laverya merged commit 461cc99 into main Oct 10, 2023
22 checks passed
@laverya laverya deleted the laverya/allow-warning-when-file-not-collected-fio branch October 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants