Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock all release data without mixing with real data #232

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Dec 23, 2024

What this PR does / why we need it:

Add better indicators for mock data:

  • Remove real channel/release info from /app/info endpoint and replace it with mock data for consistency
  • Add X-Replicated-Mock-Data: true header to responses when mock data is used.
  • Add "mock" to text fields to indicate that data is not real.
Screenshot 2024-12-23 at 12 00 29 PM

Which issue(s) this PR fixes:

Fixes https://app.shortcut.com/replicated/story/100946/integration-mode-is-messy-for-the-sdk-developer-experience-improve-sdk-integration-experience-as-part-of-calling-it-ga

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

- Adds support for mocking channelID, channelName, channelSequence, releaseSequence in current release info returned by /app/info API.

Does this PR require documentation?

@divolgin divolgin marked this pull request as ready for review December 23, 2024 20:47
@divolgin divolgin merged commit 28a6f55 into main Dec 23, 2024
11 checks passed
@divolgin divolgin deleted the divolgin/sc-100946/integration-mode-is-messy-for-the-sdk-developer branch December 23, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants