feat(snapshots): GetBackup details endpoint should support new dr #5058
+250
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGAntunes
previously approved these changes
Dec 17, 2024
pkg/handlers/backup.go
Outdated
| Success bool `json:"success"` | ||
| Error string `json:"error,omitempty"` | ||
| BackupDetails []snapshottypes.BackupDetail `json:"backupDetails"` | ||
| Deprecated_BackupDetail *snapshottypes.BackupDetail `json:"backupDetail"` |
There was a problem hiding this comment.
I wonder if this is better VS changing where we use this in the UI?
Else, should we have a store to clean this up once the UI is updated?
There was a problem hiding this comment.
Is something like this correct?
result.backupDetails && result.backupDetails.length > 0 ? result.backupDetails[0] : nullThere was a problem hiding this comment.
Or this?
result.backupDetails?.[0]
sgalsaleh
approved these changes
Dec 17, 2024
emosbaugh
deleted the
emosbaugh/sc-117471/change-the-getbackupdetail-endpoint-to-return
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support to backup details endpoint for new DR.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?