feat: [sc-117029] Add keep annotation to KOTS #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvanthao
force-pushed
the
gerard/sc-117029/keep-annotation
branch
from
e54e660 to
e5e5969
Compare
sgalsaleh
reviewed
Dec 10, 2024
| // if this is a keep resource, don't delete it | ||
| // e.g. for migration to Helm v1beta2 | ||
| if keep, ok := o.Metadata.Annotations["kots.io/keep"]; ok && keep == "true" { | ||
| logger.Infof("skipping deletion of resource %s/%s", o.Kind, o.Metadata.Name) |
There was a problem hiding this comment.
would be nice to mention the reason in the log message as well
Suggested change
| logger.Infof("skipping deletion of resource %s/%s", o.Kind, o.Metadata.Name) | |
| logger.Infof("skipping deletion of resource %s/%s because kots.io/keep annotation is set", o.Kind, o.Metadata.Name) |
sgalsaleh
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/replicated/story/117029
Demo: https://www.loom.com/share/3a33f7af9a4b4df39c2ff309aaa99f48?sid=a032f5d3-16e0-4e8a-aac9-655bacc3bfff
Changes
kots.io/keep: "true"for KOTS to skip deleting the manifest if the annotation present in non-Helm installDEBUG_KOTSADM=1 make debugto debug the code changes.