Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove quiet flag in Minio #5036

Merged
merged 3 commits into from
Dec 12, 2024
Merged

feat: remove quiet flag in Minio #5036

merged 3 commits into from
Dec 12, 2024

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Dec 9, 2024

What this PR does / why we need it:

Currently MinIO component of kotsadm runs in quiet mode and does not provide any logging output. Removing the quiet flag improves visibility into MinIO operations and helps with troubleshooting storage related issues.

Before changes in MinIO logs

After changes in MinIO logs

WARNING: MINIO_ACCESS_KEY and MINIO_SECRET_KEY are deprecated.
         Please use MINIO_ROOT_USER and MINIO_ROOT_PASSWORD
Formatting 1st pool, 1 set(s), 1 drives per set.
WARNING: Host local has more than 0 drives of set. A host failure will result in data becoming unavailable.
MinIO Object Storage Server
Copyright: 2015-2023 MinIO, Inc.
License: GNU AGPLv3 <https://www.gnu.org/licenses/agpl-3.0.html>
Version: DEVELOPMENT.2023-12-20T01-00-02Z (go1.21.6 linux/arm64)

Status:         1 Online, 0 Offline.
S3-API: http://10.1.1.66:9000  http://127.0.0.1:9000
Console: http://10.1.1.66:36627 http://127.0.0.1:36627

Documentation: https://min.io/docs/minio/linux/index.html
Warning: The standard parity is set to 0. This can lead to data loss.

 You are running an older version of MinIO released 10 months before the latest release
 Update: Run `mc admin update`

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/116844/in-cluster-default-troubleshoot-spec-does-not-collect-kotsadm-minio-logs

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@nvanthao nvanthao added the type::feature New feature or request label Dec 9, 2024
@nvanthao nvanthao force-pushed the gerard/sc-116844/minio branch from 5fcb09e to 211487a Compare December 10, 2024 05:28
@xavpaice xavpaice changed the title feat: remove quite flag in Minio feat: remove quiet flag in Minio Dec 11, 2024
@laverya
Copy link
Member

laverya commented Dec 11, 2024

@nvanthao is there any chance you could post a before+after of the minio logs here?

@nvanthao
Copy link
Member Author

thanks @laverya, I've updated the description with before+after minio logs

@laverya laverya merged commit 3ed961a into main Dec 12, 2024
122 checks passed
@laverya laverya deleted the gerard/sc-116844/minio branch December 12, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants