feat(ec): add new DR backup type ReplicatedBackup
#5032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this one in favour of #5033. |
JGAntunes
deleted the
jgantunes/sc-116339/create-a-new-replicatedbackup-type-including
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Backups we show to the user in the UI now have a specific name and can contain 1 or more backups (infra and app backups). We should create a new go type ReplicatedBackup which includes a Name, an array of Backups containing each of the individual backups it holds, an ExpectedBackupCount holding the expected number of backups for this ReplicatedBackup to hold and a field to identify this type as a new Backup type.
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/116339/create-a-new-replicatedbackup-type-including-a-name-property-and-an-array-of-backups
Does this PR require a test?
NONE we're just adding a type for now
Does this PR require a release note?
Does this PR require documentation?
NONE