Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Helm values schema validation to fetch external references when airgap #5029

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LeoColomb
Copy link

@LeoColomb LeoColomb commented Dec 3, 2024

What this PR does / why we need it:

By default, Helm will validate the values with a JSON schema if present in the chart.
Typically, if a subchart is defined as dependency, the top JSON schema includes references to subchart own JSON schema.
Often, this reference is a URI to download from “the outside”, which breaks Helm use when the environment is air-gapped.

Helm provides an option to disable values schema validation (SkipSchemaValidation), which can be use to prevent this to happening in this context.
Ideal would to check if the JSON schema (and its dependencies) contains external $refs but there is no easy way to achieve that.
In that extent, the proposed addition is fairly simple, even if it might disable JSON schema validation when it would have been possible without an error.

Which issue(s) this PR fixes:

No issue, but here is my investigation.

When running install with a Helm chart:

Does this PR require a test?

I don't think so, but please let me know if it would be required.

Does this PR require a release note?

Prevent Helm to validate values schema on a air-gapped deployment 

Does this PR require documentation?

I don't think so.


References:

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024

CLA assistant check
All committers have signed the CLA.

@LeoColomb LeoColomb changed the title Prevent Helm values schema validation to call external references when airgapped Prevent Helm values schema validation to fetch external references when airgap Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants