chore(ec): send upgrade events instead of the operator #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
reviewed
Nov 26, 2024
sgalsaleh
reviewed
Nov 26, 2024
sgalsaleh
reviewed
Nov 26, 2024
sgalsaleh
reviewed
Nov 26, 2024
| @@ -75,6 +76,11 @@ func startClusterUpgrade( | |||
|
|
|||
| log.Printf("Starting cluster upgrade to version %s...", newcfg.Version) | |||
|
|
|||
| // We cannot notify the upgrade started until the new install is created | |||
| if err := NotifyUpgradeStarted(ctx, license.Spec.Endpoint, newInstall, current, versionLabel); err != nil { | |||
There was a problem hiding this comment.
so if the upgrade fails prior to this point, we wouldn't report that an upgrade started, but we would report that it failed?
There was a problem hiding this comment.
i guess that's the caveat that you captured in the comment that the new installation object is required to report that the upgrade started. so nevermind.
There was a problem hiding this comment.
updated. im not sure if its better or worse this way
sgalsaleh
reviewed
Nov 26, 2024
sgalsaleh
previously approved these changes
Nov 26, 2024
sgalsaleh
approved these changes
Nov 26, 2024
emosbaugh
deleted the
emosbaugh/sc-116124/upgrade-events-should-be-sent-by-kots-instead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sends upgrade events instead of operator
Related replicatedhq/embedded-cluster#1527
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?